Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

querystring: improve stringify() performance #33669

Merged
merged 1 commit into from
Jun 13, 2020

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented May 31, 2020

Benchmark results:

                                                                        confidence improvement accuracy (*)   (**)  (***)
 querystring/querystring-stringify.js n=1000000 type='array'                  ***     27.37 %       ±0.86% ±1.15% ±1.50%
 querystring/querystring-stringify.js n=1000000 type='encodelast'             ***     19.40 %       ±1.27% ±1.70% ±2.24%
 querystring/querystring-stringify.js n=1000000 type='encodemany'             ***      9.39 %       ±1.33% ±1.78% ±2.34%
 querystring/querystring-stringify.js n=1000000 type='multiprimitives'        ***     56.64 %       ±1.93% ±2.59% ±3.43%
 querystring/querystring-stringify.js n=1000000 type='noencode'               ***     26.66 %       ±4.15% ±5.59% ±7.41%
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@mscdex mscdex added querystring Issues and PRs related to the built-in querystring module. performance Issues and PRs related to the performance of Node.js. labels May 31, 2020
@nodejs-github-bot
Copy link
Collaborator

@benjamingr
Copy link
Member

@bricss why are you upvoting every new PR :D?

@BridgeAR BridgeAR force-pushed the master branch 2 times, most recently from 8ae28ff to 2935f72 Compare May 31, 2020 12:18
@bricss
Copy link

bricss commented May 31, 2020

@benjamingr I wouldn't consider this as a upvote, but as regular like 🙂

lib/querystring.js Show resolved Hide resolved
lib/querystring.js Outdated Show resolved Hide resolved
lib/querystring.js Show resolved Hide resolved
@mscdex mscdex force-pushed the querystring-stringify-perf branch 2 times, most recently from d4c300d to 0ce72f8 Compare June 2, 2020 14:45
@nodejs-github-bot
Copy link
Collaborator

@mscdex mscdex force-pushed the querystring-stringify-perf branch from 0ce72f8 to 06bdb24 Compare June 3, 2020 02:29
@mscdex
Copy link
Contributor Author

mscdex commented Jun 3, 2020

I've made further changes that have netted even larger improvements across the board.

@nodejs-github-bot
Copy link
Collaborator

@mscdex mscdex force-pushed the querystring-stringify-perf branch from 06bdb24 to 7b46793 Compare June 12, 2020 22:22
@nodejs-github-bot
Copy link
Collaborator

@mscdex mscdex merged commit 7b46793 into nodejs:master Jun 13, 2020
@mscdex mscdex deleted the querystring-stringify-perf branch June 13, 2020 01:18
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@codebytere codebytere mentioned this pull request Jun 28, 2020
codebytere pushed a commit that referenced this pull request Jun 30, 2020
codebytere pushed a commit that referenced this pull request Jul 10, 2020
@codebytere codebytere mentioned this pull request Jul 13, 2020
codebytere pushed a commit that referenced this pull request Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Issues and PRs related to the performance of Node.js. querystring Issues and PRs related to the built-in querystring module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants